fix: properly support phpstan/phpdoc-parser 2 #6789
Merged
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
commented
Nov 12, 2024
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Tickets | Closes phpDocumentor/ReflectionDocBlock#386 (comment) |
| License | MIT |
| Doc PR |
xabbuh
force-pushed
the
phpstan-phpdoc-parser-2
branch
from
2fb3557
to
7f45b5f
Compare
xabbuh
changed the title
xabbuh
force-pushed
the
phpstan-phpdoc-parser-2
branch
from
7f45b5f
to
abccb4f
Compare
This was referenced Nov 12, 2024
karpilin
approved these changes
Nov 13, 2024
xabbuh
changed the title
|
Thanks @xabbuh aren't tests failures related to that? Do you know where to look for this failure? I would like to release a fix tomorrow. |
xabbuh
force-pushed
the
phpstan-phpdoc-parser-2
branch
from
abccb4f
to
fdbad07
Compare
|
The PHPUnit tests now pass given that Symfony releases fixing support for I am not sure about the failing Behat jobs though. |
soyuka
force-pushed
the
phpstan-phpdoc-parser-2
branch
from
ff4d9ad
to
ace6cdd
Compare
soyuka
force-pushed
the
phpstan-phpdoc-parser-2
branch
from
ace6cdd
to
12d7400
Compare
|
thanks @xabbuh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.